Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating configmap #190

Merged
merged 5 commits into from
Jan 28, 2024
Merged

Updating configmap #190

merged 5 commits into from
Jan 28, 2024

Conversation

Filipe-Souza
Copy link
Contributor

Context

  • Now the new server config environment variables are supported;
  • The new game world environment variables are supported;

Choices

  • Following up the docker image updates, not the most elegant solution, but checking and formatting values will be for now only for the server settings.
  • The game world settings are not validated in anyway, just injected on the container as-is;

Test instructions

Git clone the repo;
Install Helm client and check if you have access to a Kubernetes cluster (tested on v1.29);
Create your values.override.yaml file and add the properties that are pertinent to your cluster;
Run the following command:
helm install --create-namespace --namespace palworld palworld chart/ --values values.override.yaml

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

@Filipe-Souza
Copy link
Contributor Author

pod env:
Screenshot 2024-01-28 163901
Game screen:
Screenshot 2024-01-28 163838

@thijsvanloef thijsvanloef added help wanted Extra attention is needed kubernetes Issue/PR related to Kubernetes labels Jan 28, 2024
Copy link
Owner

@thijsvanloef thijsvanloef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thijsvanloef thijsvanloef merged commit b032c60 into thijsvanloef:main Jan 28, 2024
4 checks passed
MusclePr pushed a commit to MusclePr/palworld-server-docker that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed kubernetes Issue/PR related to Kubernetes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants